Skip to content

Leftover files removed. - #34

Merged
bitai-cs merged 1 commit into
mainfrom
fix/20250721-clean-files
Jul 21, 2026
Merged

Leftover files removed.#34
bitai-cs merged 1 commit into
mainfrom
fix/20250721-clean-files

Conversation

@bitai-cs

@bitai-cs bitai-cs commented Jul 21, 2026

Copy link
Copy Markdown
Owner

Summary by Sourcery

Chores:

  • Delete the Bitai.LDAPHelper.LdapAdapters project and all remaining source and docs files under that directory.

@sourcery-ai

sourcery-ai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes the obsolete Bitai.LDAPHelper.LdapAdapters project and its associated source, interface, and documentation files that are no longer needed.

File-Level Changes

Change Details Files
Remove the Bitai.LDAPHelper.LdapAdapters project and all of its leftover files from the codebase.
  • Delete the Bitai.LDAPHelper.LdapAdapters.csproj so the project is no longer built or referenced.
  • Remove interface and enum source files related to LDAP adapter abstractions that are now unused or replaced elsewhere.
  • Delete the project-specific README and LICENSE documentation files that are no longer relevant.
src/Bitai.LDAPHelper.LdapAdapters/Bitai.LDAPHelper.LdapAdapters.csproj
src/Bitai.LDAPHelper.LdapAdapters/Enums.cs
src/Bitai.LDAPHelper.LdapAdapters/IConnectionInfo.cs
src/Bitai.LDAPHelper.LdapAdapters/ILdapAttributeAdapter.cs
src/Bitai.LDAPHelper.LdapAdapters/ILdapAttributeSetAdapter.cs
src/Bitai.LDAPHelper.LdapAdapters/ILdapConnectionAdapter.cs
src/Bitai.LDAPHelper.LdapAdapters/ILdapConnectionFactoryAdapter.cs
src/Bitai.LDAPHelper.LdapAdapters/ILdapEntryAdapter.cs
src/Bitai.LDAPHelper.LdapAdapters/ILdapMessageAdapter.cs
src/Bitai.LDAPHelper.LdapAdapters/ILdapModificationAdapter.cs
src/Bitai.LDAPHelper.LdapAdapters/ILdapSearchConstraintsAdapter.cs
src/Bitai.LDAPHelper.LdapAdapters/ILdapSearchQueueAdapter.cs
src/Bitai.LDAPHelper.LdapAdapters/ISearchLimits.cs
src/Bitai.LDAPHelper.LdapAdapters/LICENSE.md
src/Bitai.LDAPHelper.LdapAdapters/README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since the entire Bitai.LDAPHelper.LdapAdapters project is removed, consider verifying and cleaning up any remaining project/solution references (e.g., .sln entries, package references, build scripts) that might still point to this project.
  • If any of the deleted adapter interfaces were part of a public API, consider whether a deprecation period or a compatibility shim is needed to avoid breaking downstream consumers that may still reference these types.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since the entire `Bitai.LDAPHelper.LdapAdapters` project is removed, consider verifying and cleaning up any remaining project/solution references (e.g., `.sln` entries, package references, build scripts) that might still point to this project.
- If any of the deleted adapter interfaces were part of a public API, consider whether a deprecation period or a compatibility shim is needed to avoid breaking downstream consumers that may still reference these types.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@bitai-cs
bitai-cs merged commit ae8f0ba into main Jul 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant