Update/20260606 tests mocks - #26
Merged
Merged
Conversation
Contributor
Reviewer's GuideDecouples LDAP mocks and mock data seeding from the demo project into a reusable test-mocks package and formalizes adapter interfaces for connection and search limits, updating all adapters and demo wiring accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new persistent mock connection type is named
MockLdapPersistenConnectionAdapter(missing the trailing 't'); consider renaming it (and the file) toMockLdapPersistentConnectionAdapterfor consistency and easier discoverability alongsideMockLdapPersistentConnectionFactoryAdapter. - In
MockLdapPersistentConnectionFactoryAdapter.CreateConnectionAsyncyou call_connection.BindAsync(userAccount, password)without awaiting it; if bind failures should be observable to callers, consider awaiting this task (and propagating exceptions) before returning the connection.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new persistent mock connection type is named `MockLdapPersistenConnectionAdapter` (missing the trailing 't'); consider renaming it (and the file) to `MockLdapPersistentConnectionAdapter` for consistency and easier discoverability alongside `MockLdapPersistentConnectionFactoryAdapter`.
- In `MockLdapPersistentConnectionFactoryAdapter.CreateConnectionAsync` you call `_connection.BindAsync(userAccount, password)` without awaiting it; if bind failures should be observable to callers, consider awaiting this task (and propagating exceptions) before returning the connection.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decoupled data-persistent ldap mocks.
Summary by Sourcery
Extract LDAP adapter contracts into a dedicated abstraction project and update mocks and demo code to use adapter interfaces and a persistent in-memory LDAP data store for testing and demo scenarios.
New Features:
Enhancements:
Documentation:
Tests: