.NET 10 upgrade - #25
Merged
Merged
Conversation
Contributor
Reviewer's Guide.NET SDK and solution have been upgraded to target .NET 10, CI has been introduced via GitHub Actions, and several library messages and documentation strings were updated to consistently use "username" terminology instead of "user account" while keeping functional behavior the same. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- In
AccountManagerAdapterTests.CreateUserAccountForMsAD_ReturnsSuccess, the assertion now expects"account nameX created at"but the production message is"Account name created at ...", so the extraXwill cause this test to fail and should be removed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `AccountManagerAdapterTests.CreateUserAccountForMsAD_ReturnsSuccess`, the assertion now expects `"account nameX created at"` but the production message is `"Account name created at ..."`, so the extra `X` will cause this test to fail and should be removed.
## Individual Comments
### Comment 1
<location path="tests/Bitai.LDAPHelper.Tests/AccountManagerAdapterTests.cs" line_range="38" />
<code_context>
// Assert
Assert.True(result.IsSuccessfulOperation);
- Assert.Contains("user account created at", result.OperationMessage.ToLower());
+ Assert.Contains("account nameX created at", result.OperationMessage.ToLower());
}
</code_context>
<issue_to_address>
**issue (testing):** The assertion string appears to have a typo and no longer matches the updated operation message format.
This test now checks for `"account nameX created at"` while the implementation emits `"Account name created at {DN} with sAMAccountName: {SAM}"`, so the assertion is inconsistent and fragile. Please update the expected substring to match the new format and, ideally, assert that both the DN and `sAMAccountName` appear in `OperationMessage` so the test validates the key data rather than just a human‑readable phrase.
</issue_to_address>
### Comment 2
<location path="README.md" line_range="23" />
<code_context>
+- **Disable Accounts** (`DisableUserAccountForMsAD`): Securely disables accounts by updating the `userAccountControl` attribute with the `ACCOUNTDISABLE` flag, dynamically preserving all other existing account name flags to prevent unintended configuration loss.
</code_context>
<issue_to_address>
**issue (typo):** Consider removing "name" in "account name flags" for clarity.
This looks like a leftover from the previous "account flags" wording; since `userAccountControl` is a set of account flags, consider reverting to that phrase (or similar) to avoid confusion.
```suggestion
- **Disable Accounts** (`DisableUserAccountForMsAD`): Securely disables accounts by updating the `userAccountControl` attribute with the `ACCOUNTDISABLE` flag, dynamically preserving all other existing account flags to prevent unintended configuration loss.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.NET 10 and Component upgrades.
Additional some library messages fixes.
Summary by Sourcery
.NET 10 upgrade and project housekeeping across solution, build, and messaging.
Enhancements:
CI:
Documentation:
Tests:
Chores: