FIX: use DatasetType instead of DataType in dataset_description.json - #52
Open
anaharrismatnez wants to merge 4 commits into
Open
FIX: use DatasetType instead of DataType in dataset_description.json#52anaharrismatnez wants to merge 4 commits into
anaharrismatnez wants to merge 4 commits into
Conversation
updates: - [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v6.0.0](pre-commit/pre-commit-hooks@v4.4.0...v6.0.0) - https://github.com/psf/black → https://github.com/psf/black-pre-commit-mirror - [github.com/psf/black-pre-commit-mirror: 24.3.0 → 26.5.1](psf/black-pre-commit-mirror@24.3.0...26.5.1)
…onfig [pre-commit.ci] pre-commit autoupdate
demiregeortac666
left a comment
demiregeortac666
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution, and welcome! DatasetType is the right key, utils/bids.py already writes it, so this closes the gap where rsHRF rejected its own output.
I have retargeted this to develop branch (that is where fixes land before a release). The six BIDS failures are from test_cli.py still writing DataType in its fixtures; Could you update those here? A NEWS.md entry summarizing your changes under the Unreleased section would be great too, and then this is perfectly fine to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the lookup of the dataset type in
CLI.py.The current implementation searches for the
DataTypefield in dataset_description.json. However, according to the BIDS specification, the correct field name isDatasetType.