fix(ui): brand mark — broken-image alt text leaked into pill (v0.9.10)#41
Open
bemoshiur wants to merge 1 commit into
Open
fix(ui): brand mark — broken-image alt text leaked into pill (v0.9.10)#41bemoshiur wants to merge 1 commit into
bemoshiur wants to merge 1 commit into
Conversation
Caught during browser self-verification of v0.9.9: every page rendered a broken-image icon plus the alt text "MOCSLA — Mailing Operator & Courier Services Licensing Authority" inside the 36px brand box on the top-left, with each word wrapping onto its own line. This was the source of the "this section is broken" mobile screenshot the user reported earlier; the v0.9.8 hero-shrink fix addressed a different shrink issue but missed this one. Root cause: brand-mark.tsx tried to load /mocsla-logo.png first and fell back to the SVG via onError. But /mocsla-logo.png was never shipped — every page render started with a broken-image render, and the alt text rendered inside the constrained 36px box. Fix: render the SVG directly. When a real PNG ships into apps/web/public/, restore the <img> path with a graceful fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the broken
<img src="/mocsla-logo.png">first-load attempt in BrandMark. The PNG was never shipped, so every page rendered a broken-image icon plus the long alt text wrapping inside the 36px brand box. This is the real source of the original 'this section is broken' mobile report.Renders the SVG directly. When a real PNG ships, restore the
<img>path with proper handling.Browser-verified at 1440px and 375px — broken column gone, brand pill clean.
🤖 Generated with Claude Code