fix(ci): ship a PNG icon for the AppImage#37
Merged
Merged
Conversation
linuxdeploy's icon deploy uses CImg, which cannot read .ico files, and the ubuntu runner ships no ImageMagick to convert at build time — so the AppImage step fell back to the raw .ico and failed: ERROR: CImg... Failed to recognize format of file '...rustcat.ico' Commit a pre-generated 256x256 assets/rustcat.png (derived from appIcon.ico) and point linuxdeploy at it directly. This removes the runtime ImageMagick dependency entirely. Co-Authored-By: Claude <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linuxdeploy's icon deploy uses CImg, which cannot read .ico, and the ubuntu runner has no ImageMagick — so the AppImage step fell back to the raw .ico and failed:
This commits a pre-generated 256x256
assets/rustcat.png(derived fromappIcon.ico) and points linuxdeploy at it directly, removing the runtime ImageMagick dependency. The AppImage step stayscontinue-on-errorso it can never block the core deb/rpm/tarball artifacts.🤖 Generated with Claude Code