fix: resolve CI failures introduced by PR #2 quality gates#13
Merged
Conversation
- backend: remove 4 unused imports (F401) via ruff --fix: * fastapi.Request in app/main.py * sqlalchemy.ext.asyncio.async_sessionmaker in app/main.py * math in tests/test_errors.py * unittest.mock.MagicMock in tests/test_http_client.py - backend: suppress E402 on intentional late import in agent/vecna_litellm.py (import litellm must follow litellm_main patching) - frontend: regenerate package-lock.json so npm ci succeeds (was missing @emnapi/core@1.11.1, @emnapi/runtime@1.11.1; had wrong @emnapi/wasi-threads version) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #2 (
add-data-quality-checks) introduced CI quality gates that immediately fail on their own codebase. This draft PR fixes the root causes so the gates go green.Root causes & fixes
1. Backend —
ruff check .(5 errors)Four unused-import (F401) errors auto-fixed via
ruff check --fix, one E402 suppressed with# noqa:backend/app/main.py:9fastapi.Requestimported but unusedbackend/app/main.py:14sqlalchemy.ext.asyncio.async_sessionmakerimported but unusedbackend/tests/test_errors.py:5mathimported but unusedbackend/tests/test_http_client.py:5unittest.mock.MagicMockimported but unusedbackend/agent/vecna_litellm.py:80# noqa: E402— theimport litellmmust followlitellm_mainpatching; the position is intentionalVerified locally:
ruff check .now reports "All checks passed!"2. Frontend —
npm cifailure (lock file out of sync)package-lock.jsonwas missing entries for@emnapi/core@1.11.1and@emnapi/runtime@1.11.1, and had a version mismatch for@emnapi/wasi-threads. Fixed by runningnpm installinfrontend/to regenerate a consistent lock file.Verified locally:
npm ci✅npm run build✅ (tsc + vite build, 271 KB bundle)3. CI gate (required check)
The required gate only failed as a downstream consequence of the above two. No separate change needed — it should go green once this PR is merged into
add-data-quality-checks.Test plan
add-data-quality-checksand verify PR reliability: add CI quality gates (tests, lint, type-check, PR-size) #2's CI goes greenOut of scope
🤖 Generated with Claude Code