Skip to content

#3958 - E2E Tests for get application offering change API - #6508

Merged
dheepak-aot merged 2 commits into
mainfrom
3958-application-offering-change-e2e-tests
Aug 21, 2026
Merged

#3958 - E2E Tests for get application offering change API#6508
dheepak-aot merged 2 commits into
mainfrom
3958-application-offering-change-e2e-tests

Conversation

@dheepak-aot

Copy link
Copy Markdown
Collaborator

E2E Tests

ApplicationOfferingChangeRequestInstitutionsController(e2e)-getApplicationOfferingChangeRequestShould get the application offering change request when application offering change request exists. (235 ms)
    √ Should throw not found exception when application offering change request does not exist. (18 ms)
    √ Should throw forbidden exception when the institution user does not have access to application location. (127 ms)

@dheepak-aot
dheepak-aot requested a lite review from Copilot August 21, 2026 22:30
@dheepak-aot dheepak-aot self-assigned this Aug 21, 2026
@dheepak-aot dheepak-aot changed the title #3958 - Added E2E Tests for get application offering change API #3958 - E2E Tests for get application offering change API Aug 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds E2E coverage for the institutions API retrieving application offering change requests.

Changes:

  • Tests successful retrieval.
  • Tests not-found and forbidden scenarios.
  • Adds a reusable endpoint helper.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

applicationOfferingChange.application.location.id,
applicationOfferingChange.id,
),
) // Non-existing application offering change request id.
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 19.93% ( 4855 / 24365 )
Methods: 9.71% ( 288 / 2967 )
Lines: 24.29% ( 4147 / 17076 )
Branches: 9.72% ( 420 / 4322 )

@github-actions

Copy link
Copy Markdown

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 48.57% ( 2930 / 6032 )
Methods: 38.11% ( 306 / 803 )
Lines: 55.35% ( 2209 / 3991 )
Branches: 33.52% ( 415 / 1238 )

@github-actions

Copy link
Copy Markdown

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 80.94% ( 9874 / 12199 )
Methods: 80.65% ( 1292 / 1602 )
Lines: 84.33% ( 7367 / 8736 )
Branches: 65.29% ( 1215 / 1861 )

@weskubo-cgi weskubo-cgi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these tests.

@uhelm
uhelm self-requested a review August 21, 2026 23:00

@uhelm uhelm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@github-actions

Copy link
Copy Markdown

E2E SIMS API Coverage Report

Totals Coverage
Statements: 70.36% ( 14950 / 21248 )
Methods: 67.96% ( 1784 / 2625 )
Lines: 73.47% ( 10660 / 14510 )
Branches: 60.93% ( 2506 / 4113 )

@dheepak-aot
dheepak-aot added this pull request to the merge queue Aug 21, 2026
Merged via the queue into main with commit a064a9c Aug 21, 2026
26 of 27 checks passed
@dheepak-aot
dheepak-aot deleted the 3958-application-offering-change-e2e-tests branch August 21, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants