Skip to content

DBC22-6169: Fixed long delays and blank image showing when turning on/off cameras - #1394

Merged
wmuldergov merged 5 commits into
mainfrom
bugfix/DBC22-6169
Aug 18, 2026
Merged

DBC22-6169: Fixed long delays and blank image showing when turning on/off cameras#1394
wmuldergov merged 5 commits into
mainfrom
bugfix/DBC22-6169

Conversation

@bcgov-brwang

@bcgov-brwang bcgov-brwang commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

📝 Submitter

🔗 JIRA Ticket

✅ Quality Assurance & Requirements

  • Requirements Met: I have confirmed that all acceptance criteria from the JIRA ticket are fulfilled.
  • Tested desktop in local or dev envs
  • Tested mobile in local or dev envs
  • Ran unit tests locally
  • SonarCloud: I have verified that the SonarCloud analysis is clean/passing for this branch.

⚙️ Configuration & Environment

  • New Env Variables: Does this PR require new environment variables? (Yes/No)

    If yes, please list them here and ensure they are added to secret manager, the .env.example. and the Vault by an STA.

🧪 How to Test (if required)

  1. Deploy to dev.
  2. Go to a camera detail page.
  3. Turn on a camera (i.e., camera 11) from camera control panel. (https://dev.drivebc.ca/cameras/11?pan=-118.21833040000001%2C51.0072615&zoom=12)
  4. Verify the unavailable image shows up within a min.
  5. Verify the image is a blank image. (https://dev.drivebc.ca/images/11.jpg).
  6. Turn the camera back on.
  7. Verify the image shows up within a min.
  8. Verify the image is not a blank image.
  9. This ticket combined fixes for reducing update database call when updating Webcam database, verify Excessive UPDATE queries are removed by reviewing WAL log.

🔍 Reviewer Checklist

  • Reviewed code for logic and cleanliness
  • Re-tested desktop/mobile in local or dev envs
  • Verified no new console warnings/errors
  • Confirmed that any new env variables are understood/documented

github-code-quality[bot]
github-code-quality Bot found potential problems Jul 20, 2026
View reviewed changes
Comment thread src/backend/apps/webcam/models.py Fixed
Comment thread src/backend/apps/webcam/models.py Fixed
github-code-quality[bot]
github-code-quality Bot found potential problems Jul 20, 2026
View reviewed changes
Comment thread src/backend/apps/webcam/tasks.py Fixed
github-code-quality[bot]
github-code-quality Bot found potential problems Jul 21, 2026
View reviewed changes
Comment thread src/backend/apps/webcam/tasks.py Fixed
github-code-quality[bot]
github-code-quality Bot found potential problems Jul 22, 2026
View reviewed changes
Comment thread src/backend/apps/webcam/tests/test_tasks.py Fixed
@bcgov-brwang bcgov-brwang changed the title Bugfix/dbc22 6169 DBC22-6169: Fixed long delays and blank image showing when turning on/off cameras Jul 22, 2026
@bcgov-brwang
bcgov-brwang requested a review from wmuldergov July 22, 2026 23:04
@bcgov-brwang bcgov-brwang added the ready for review The PR is ready for review label Jul 22, 2026
@bcgov-brwang
bcgov-brwang marked this pull request as ready for review July 22, 2026 23:05
@wmuldergov

wmuldergov commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

I think this relates to https://moti-imb.atlassian.net/browse/DBC22-6979 so are you able to look into that as part of this work?

@bcgov-brwang bcgov-brwang added ready for review The PR is ready for review and removed pending rework If the PR needs some re-work by the developer labels Aug 18, 2026
github-code-quality[bot]
github-code-quality Bot found potential problems Aug 18, 2026
View reviewed changes
Comment thread src/backend/apps/consumer/processor.py Fixed
Comment thread src/backend/apps/consumer/processor.py Fixed
Comment thread src/backend/apps/webcam/tasks.py Fixed
@bcgov-brwang
DBC22-6169: merged from latest main
1e67d96 
DBC22-6169: removed long running process monitoring camera status

DBC22-6169: debug test

DBC22-6169: debug test 1

DBC22-6169: debug test for remove backup and restore logic

DBC22-6169: debug test for remove backup and restore logic 2
wmuldergov
wmuldergov reviewed Aug 18, 2026
View reviewed changes
Comment thread src/backend/apps/consumer/tests/test_tasks.py Outdated
wmuldergov
wmuldergov reviewed Aug 18, 2026
View reviewed changes
Comment thread compose/backend/leader-election.py Outdated
wmuldergov
wmuldergov reviewed Aug 18, 2026
View reviewed changes
Comment thread src/backend/apps/consumer/tests/test_tasks.py Outdated
wmuldergov
wmuldergov reviewed Aug 18, 2026
View reviewed changes
Comment thread src/backend/apps/consumer/tests/test_tasks.py Outdated
wmuldergov
wmuldergov reviewed Aug 18, 2026
View reviewed changes
Comment thread src/backend/apps/consumer/processor.py Outdated
github-code-quality[bot]
github-code-quality Bot found potential problems Aug 18, 2026
View reviewed changes
Comment thread src/backend/apps/webcam/tests/test_tasks.py Fixed
Comment thread src/backend/apps/webcam/tests/test_tasks.py Fixed
@sonarqubecloud

sonarqubecloud Bot commented Aug 18, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

wmuldergov
wmuldergov approved these changes Aug 18, 2026
View reviewed changes

@wmuldergov wmuldergov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be working as expected now.

@wmuldergov
wmuldergov merged commit ba6b0e7 into main Aug 18, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmuldergov wmuldergov wmuldergov approved these changes
+1 more reviewer
@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready for review The PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bcgov-brwang @wmuldergov