Skip to content

Fix rust-analyzer proc-macro merge for k8-opt-exec paths#4140

Merged
UebelAndre merged 1 commit into
bazelbuild:mainfrom
TrapsterDK:fix-ra-opt-exec-proc-macro-merge
Jul 8, 2026
Merged

Fix rust-analyzer proc-macro merge for k8-opt-exec paths#4140
UebelAndre merged 1 commit into
bazelbuild:mainfrom
TrapsterDK:fix-ra-opt-exec-proc-macro-merge

Conversation

@TrapsterDK

@TrapsterDK TrapsterDK commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Written by AI, reviewed by human.

Fixes #4139.

Summary

consolidate_crate_specs prefers proc-macro dylib paths that look like exec outputs. The previous marker matched paths with -opt-exec-, but Bazel can also emit exec paths like bazel-out/k8-opt-exec/bin/....

This updates the marker to match both forms and adds a regression test for the unsuffixed k8-opt-exec/bin path shape.

Testing

bazel test --cache_test_results=no //tools/rust_analyzer:gen_rust_project_lib_test

@google-cla

google-cla Bot commented Jul 8, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@UebelAndre UebelAndre left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@UebelAndre UebelAndre added this pull request to the merge queue Jul 8, 2026
Merged via the queue into bazelbuild:main with commit 7cd42b8 Jul 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rust-analyzer proc-macro consolidation drops exec dylib under k8-opt-exec/bin

2 participants