fix: intercept upstream's self-SIGKILL fallback in e8s() - #253
Merged
Conversation
Upstream's final-exit helper (e8s) does `try { process.exit(e) }
catch(t) { process.kill(process.pid, "SIGKILL") }`. Because the Termux
wrapper monkeypatches process.exit to throw RequestedExit, this throw
gets caught by e8s's own catch, which force-kills the process via a
raw SIGKILL that bypasses the wrapper's RequestedExit/print-flush
handling entirely. Intercept self-directed SIGKILL the same way, so
it flows through the existing RequestedExit path instead.
Confirmed via manual instrumentation on-device: with PRINT_WAIT_MS=30000
(previously killed 9/9 runs around 7-11s), this fix produced 3/3 clean
exits with full output.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bash0816
added a commit
that referenced
this pull request
Jul 29, 2026
Termux wrapper-only fix (process.kill self-SIGKILL interception, PR #253), no upstream version change. Adds 2.1.220-2 offset_discovered entry (same native binary/offsets as 2.1.220-1, which is already published to npm and cannot be republished under the same version) and bumps package.json/manifest to 2.1.220-2 candidate. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code