Skip to content

docs: add --fault-proofs flag to base-mainnet withdrawal commands - #84

Open
erhnysr wants to merge 1 commit into
base:mainfrom
erhnysr:fix/readme-fault-proofs-flag
Open

docs: add --fault-proofs flag to base-mainnet withdrawal commands#84
erhnysr wants to merge 1 commit into
base:mainfrom
erhnysr:fix/readme-fault-proofs-flag

Conversation

@erhnysr

@erhnysr erhnysr commented Jun 8, 2026

Copy link
Copy Markdown

Fixes #78.

base-mainnet has faultProofs: true in main.go, so the CLI exits with an error when --fault-proofs is not provided. The README's Without Fault Proofs section showed base-mainnet commands without this required flag, causing users who copy the commands to get an immediate error.

Added --fault-proofs to all three base-mainnet commands in the README (prove step, finalize step, and Ledger variant).

@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@conceito082biu-creator conceito082biu-creator left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cb-heimdall

Copy link
Copy Markdown
Collaborator

Review Error for conceito082biu-creator @ 2026-07-28 18:21:51 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README shows base-mainnet withdrawal commands without required --fault-proofs flag

3 participants