Harden telemetry error handling and type safety in Account SDK - #388
Open
mertcano wants to merge 1 commit into
Open
Harden telemetry error handling and type safety in Account SDK#388mertcano wants to merge 1 commit into
mertcano wants to merge 1 commit into
Conversation
This PR addresses error handling and type-safety anti-patterns in the Account SDK telemetry core: - **`utils.ts`**: Replaced generic caught types with `unknown`, applying strict null and object guards before property access to prevent secondary `TypeError` exceptions during error message extraction. - **`initCCA.ts`**: Normalized asynchronous thrown telemetry values into proper `Error` instances, ensuring proper error logging and preserving the original failure context on rejection.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses error handling and type-safety anti-patterns in the Account SDK telemetry core:
utils.ts: Replaced generic caught types withunknown, applying strict null and object guards before property access to prevent secondaryTypeErrorexceptions during error message extraction.initCCA.ts: Normalized asynchronous thrown telemetry values into properErrorinstances, ensuring proper error logging and preserving the original failure context on rejection.