Skip to content

fix(prolink): preserve payload query param - #382

Open
omerbek wants to merge 1 commit into
base:masterfrom
omerbek:fix/prolink-param-order
Open

fix(prolink): preserve payload query param#382
omerbek wants to merge 1 commit into
base:masterfrom
omerbek:fix/prolink-param-order

Conversation

@omerbek

@omerbek omerbek commented Aug 13, 2026

Copy link
Copy Markdown

Summary

Fixes #376.

  • Applies additional query params before setting the required p payload parameter.
  • Ensures additionalQueryParams.p cannot overwrite the encoded prolink payload.
  • Adds a regression test covering the overwrite case while preserving other additional params.

Testing

corepack yarn install --immutable
# completed with existing peer dependency warnings

corepack yarn workspace @base-org/account exec vitest run src/interface/public-utilities/prolink/createProlinkUrl.test.ts
# passed, 22 tests

corepack yarn biome check packages/account-sdk/src/interface/public-utilities/prolink/createProlinkUrl.ts packages/account-sdk/src/interface/public-utilities/prolink/createProlinkUrl.test.ts
# passed

git diff --check
# passed

Note: corepack yarn workspace @base-org/account typecheck currently fails in this clean checkout because src/ui/Dialog/Dialog.tsx imports generated ./Dialog-css.js; this PR only touches the prolink utility and test.

@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: createProlinkUrl additional params can overwrite the prolink payload

2 participants