fix(web): emit web vitals under the web.vital.* namespace (v0.1.15) - #4
Merged
Merged
Conversation
The five core Web Vitals attributes were emitted without the `web.` prefix (`vital.name`, `vital.value`, `vital.rating`, `vital.id`, `vital.target_selector`) while every sibling attribute in the same block (`web.vital.cls.*`, `web.vital.inp.*`, `web.vital.lcp.*`), the emitted metrics (`web.vital.lcp`, `web.vital.fcp`, ...) and the root-span rollups (`web.vital.<name>.value`) already used it. Backends project `web.vital.name`/`value`/`rating`, so those reads came back empty and `web_vital` events rendered with no name and no measurement -- observed on session bf92606f-a07d-4a3b-8590-b268829863ac, where the spans carried correct data under the wrong keys. The old names also collided with the mobile `app_vital` schema, which owns `vital.name` and `vital.type`, putting two different schemas on one key. Attributes are asserted as literal strings rather than via `ATTR.*` so a future rename of a constant cannot keep the test green while the wire format regresses. Telemetry already ingested keeps the old attribute names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five core Web Vitals attributes were emitted without the
web.prefix (vital.name,vital.value,vital.rating,vital.id,vital.target_selector) while every sibling attribute in the same block (web.vital.cls.*,web.vital.inp.*,web.vital.lcp.*), the emitted metrics (web.vital.lcp,web.vital.fcp, ...) and the root-span rollups (web.vital.<name>.value) already used it.Backends project
web.vital.name/value/rating, so those reads came back empty andweb_vitalevents rendered with no name and no measurement -- observed on session bf92606f-a07d-4a3b-8590-b268829863ac, where the spans carried correct data under the wrong keys.The old names also collided with the mobile
app_vitalschema, which ownsvital.nameandvital.type, putting two different schemas on one key.Attributes are asserted as literal strings rather than via
ATTR.*so a future rename of a constant cannot keep the test green while the wire format regresses.Telemetry already ingested keeps the old attribute names.