feat(androidtv): add Projectivy deployment helper#12
Conversation
|
Warning Review limit reached
Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughAdds ChangesProjectivy deployment
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Operator
participant projectivy_deploy_sh
participant ADB
participant Android_TV
Operator->>projectivy_deploy_sh: Select install, restore, backup, or launcher-only mode
projectivy_deploy_sh->>ADB: Resolve and invoke adb
ADB->>Android_TV: Connect and wait for device
projectivy_deploy_sh->>Android_TV: Install or validate Projectivy
projectivy_deploy_sh->>Android_TV: Perform backup or restore when requested
projectivy_deploy_sh->>Android_TV: Set Projectivy as default home activity
Android_TV-->>Operator: Launcher is available from Home
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@projectivy-deploy.sh`:
- Line 9: Replace the site-specific default in projectivy-deploy.sh at lines 9-9
with a generic ADB container name, and update the description at lines 3-3 and
EOF help text at lines 16-16 to reference the same new default.
- Around line 42-45: Update the containerized `adb_cmd` flow so host paths are
not passed directly to `docker exec`: copy `$APK_PATH` and `$RESTORE_PATH` into
a temporary container directory before install/restore, and copy the backup
produced by `adb backup` back to `$BACKUP_PATH` before the existing size check.
Apply this only when using the `ADB_CONTAINER` branch while preserving direct
host-path behavior for local adb execution.
- Line 96: Replace the GNU-specific stat invocation in the backup-size printf
with a POSIX-compatible wc -c approach, preserving the existing “missing”
fallback when the backup file cannot be read.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: d1cf3d89-8f58-4909-aece-ce07013f8bd3
📒 Files selected for processing (3)
CLAUDE.mdREADME.mdprojectivy-deploy.sh
All three findings were addressed in commit 60fdfff: generic container default, host/container file staging, and portable backup sizing.
Summary
Intended fleet split
Validation
No site-specific hosts, credentials, endpoints, or secrets are included. The existing authoritative infrastructure source remains unchanged.