fix(parser): two diagnostic gaps that silently dropped symbol-based dependencies - #61
Merged
Conversation
`- Consumes: \`x\`` hit the length>1 anti-prose filter and got the generic "no backtick-quoted symbols" warning — false, the line has one. The warning now names the real cause and cites the dropped symbol, so a user who named a symbol `x` knows to rename it instead of hunting a phantom formatting bug.
A header typo (**Interface:**, **Interfaz:**) silently erased every symbol-based dependency of the task — the single most destructive parse miss and the only silent one: an empty value warns, a prose-only line warns, an orphan consumer warns. extractSection flattened no-match and empty-match into '', which is the root cause; parseInterfaces now distinguishes them via extractOptionalSection and warns, suggesting an explicit "None". Also documents the header-must-be-present rule in skills/plan/SKILL.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two diagnostic gaps in
src/plan-parser.jsfound by an external review with empirical reproduction: a symbol-based dependency can vanish from the plan's DAG without a useful warning, so a task that should have been serialized instead runs in parallel with its producer (fails/BLOCKED, or implements against stale code). Neither fix changes the graph a well-formed plan produces — both only make the diagnostics honest.Type of change
Main changes
`x`) got the generic "no backtick-quoted symbols" warning — false, the line has one. The warning now names the real cause and cites the dropped symbol.**Interfaces:**section entirely (typically a header typo) silently produced emptyconsumes/produceswith no warning — the single most destructive parse miss and, until now, the only silent one. Now warns and suggests writingNoneexplicitly.skills/plan/SKILL.md: documents that the**Interfaces:**header itself must always be present.plan-parser.jsis not inlined into the generated workflow (npm run build+git diff --exit-code workflows/parallel-plan-executor.js— no change).Version
Checklist
npm test), TDD (RED confirmed for each fix before GREEN)