Skip to content

tests: move provided.al2 to the deprecated lint list and stop rerunning a non-rerun-safe sync test #9190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roger-zhangg merged 1 commit into from
Aug 18, 2026
+5 −1
Merged

tests: move provided.al2 to the deprecated lint list and stop rerunning a non-rerun-safe sync test #9190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/integration/sync/test_sync_adl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
import os.path
from unittest import skipIf

import pytest

from samcli.commands._utils.experimental import set_experimental, ExperimentalFlag
from samcli.lib.utils.resources import AWS_LAMBDA_FUNCTION, AWS_LAMBDA_LAYERVERSION
from tests.integration.sync.sync_integ_base import SyncIntegBase
Expand All @@ -16,6 +18,8 @@ class TestSyncAdlCasesWithCodeParameter(TestSyncCodeBase):
folder = "code"
dependency_layer = True

# Not rerun-safe: it edits test data in place and the class-scoped infra sync is not redone.
@pytest.mark.flaky(reruns=0)
def test_sync_code_function_without_dependencies(self):
# CFN Api call here to collect all the stack resources
self.stack_resources = self._get_stacks(TestSyncCode.stack_name)
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/validate/test_validate_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ def test_lint_template(self, relative_folder: str, expected_file: TemplateFileTy
("ruby3.2",),
("dotnet6",),
("nodejs20.x"),
("provided.al2",),
]
)
def test_lint_deprecated_runtimes(self, runtime):
Expand Down Expand Up @@ -215,7 +216,6 @@ def test_lint_supported_runtimes(self):
"java8.al2",
"nodejs22.x",
"nodejs24.x",
"provided.al2",
"provided.al2023",
"python3.10",
"python3.11",
Expand Down
Loading