fix: omit Husky from published package installs - #206
Draft
Pybsama wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #205
Description of changes:
The published package currently runs
postinstall: husky, but Husky is adevelopment dependency and is not available in a clean consumer install.
This keeps the repository's Yarn 3 contributor hook setup intact while using
Husky's documented Yarn publishing pattern:
pinst --disableruns before packing, so the published manifest has noactive
postinstall;pinst --enablerestores the source manifest after packing; andoffline, development-dependency-free npm consumer.
The smoke test places a failing Husky guard ahead of the repository's own
node_modules/.bin, so the regression cannot pass by accidentally finding thecheckout's development dependency. It also restores the source manifest in a
finallyblock if packing fails.Validation:
corepack yarn install --immutablecorepack yarn test --runInBand(25/25)corepack yarn test:package-installcorepack yarn lintcorepack yarn typescriptcorepack yarn preparenpm packfollowed by offline npm and Yarn 3 consumer installscorepack yarn prettier --check package.json .github/workflows/pr.yaml scripts/test-package-install.jsgit diff --checkBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.