add support for secret object, and allow adding CRD validation field#723
add support for secret object, and allow adding CRD validation field#723mkl262 wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mkl262 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ack-prow
Bot
added
the
needs-ok-to-test
|
Hi @mkl262. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Allow generated APIs to reference Secrets whose data keys are controlled by the controller.
support creation of x-kubernetes-validations fields in crd definitions
| // IsSecretReference instructs the code generator that this field should be | ||
| // a name/namespace-only SecretReference. Use this when the controller owns | ||
| // the Secret data key convention instead of accepting a user-selected key. | ||
| IsSecretReference bool `json:"is_secret_reference"` |
There was a problem hiding this comment.
i'm not sure if the difference between Secret and SecretReference is clear just from the names.
There was a problem hiding this comment.
maybe it can be something like isTLSSecret?
There was a problem hiding this comment.
I thought of it as a generlized catch all for secrets that have a predefined structure, such as docker config, TLS, or ssh type secrets.
2 participants
Issue #, if available:
required for aws-controllers-k8s/acm-controller#104
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.