Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions common/msg.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,21 @@ type Message struct {
BlockDigestRequest *BlockDigestRequest
}

func (m *Message) IsReplicationMessage() bool {
switch {
case m.ReplicationResponse != nil:
return true
case m.ReplicationRequest != nil:
return true
case m.VerifiedReplicationResponse != nil:
return true
case m.BlockDigestRequest != nil:
return true
default:
return false
}
}

type EmptyVoteMetadata struct {
Round uint64
Epoch uint64
Expand Down
93 changes: 93 additions & 0 deletions common/msg_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (C) 2019-2025, Ava Labs, Inc. All rights reserved.
// See the file LICENSE for licensing terms.

package common_test

import (
Expand All @@ -9,6 +12,96 @@ import (
"github.com/stretchr/testify/require"
)

func TestIsReplicationMessage(t *testing.T) {
tests := []struct {
name string
msg common.Message
expected bool
}{
{
name: "empty message",
msg: common.Message{},
expected: false,
},
{
name: "replication request",
msg: common.Message{ReplicationRequest: &common.ReplicationRequest{}},
expected: true,
},
{
name: "replication response",
msg: common.Message{ReplicationResponse: &common.ReplicationResponse{}},
expected: true,
},
{
name: "verified replication response",
msg: common.Message{VerifiedReplicationResponse: &common.VerifiedReplicationResponse{}},
expected: true,
},
{
name: "block message",
msg: common.Message{BlockMessage: &common.BlockMessage{}},
expected: false,
},
{
name: "verified block message",
msg: common.Message{VerifiedBlockMessage: &common.VerifiedBlockMessage{}},
expected: false,
},
{
name: "empty notarization",
msg: common.Message{EmptyNotarization: &common.EmptyNotarization{}},
expected: false,
},
{
name: "vote",
msg: common.Message{VoteMessage: &common.Vote{}},
expected: false,
},
{
name: "empty vote",
msg: common.Message{EmptyVoteMessage: &common.EmptyVote{}},
expected: false,
},
{
name: "notarization",
msg: common.Message{Notarization: &common.Notarization{}},
expected: false,
},
{
name: "finalize vote",
msg: common.Message{FinalizeVote: &common.FinalizeVote{}},
expected: false,
},
{
name: "finalization",
msg: common.Message{Finalization: &common.Finalization{}},
expected: false,
},
{
// A block digest request is a request but not a replication message.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we send this?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah probably

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name: "block digest request",
msg: common.Message{BlockDigestRequest: &common.BlockDigestRequest{}},
expected: true,
},
{
// When several fields are set, any replication field makes it a replication message.
name: "block message and replication request",
msg: common.Message{
BlockMessage: &common.BlockMessage{},
ReplicationRequest: &common.ReplicationRequest{},
},
expected: true,
},
}

for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
require.Equal(t, test.expected, test.msg.IsReplicationMessage())
})
}
}

func TestQuorumRoundMalformed(t *testing.T) {
tests := []struct {
name string
Expand Down
Loading
Loading