Fix monkey patch - #9
Merged
Merged
Conversation
…ite-less-build-monkey-patches-v16 fix: avoid monkey patch loading during site-less builds
…ulticurrency-bank-charges-group fix: add dedicated group for multicurrency bank charges
The patched frappe.get_hooks loads monkey patches on every call, which triggers frappe.get_installed_apps() and forces a DB connection. In site-less contexts like `bench build`, no site is bound, so connect() fails with "site must be fully initialized, db_name missing" — breaking app installation during the asset build step. Bail out of load_monkey_patches() when frappe.local.site is not set, before marking patches as loaded, so the patched frappe.connect still loads them once a real site connection is established.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.