fix: report deployment apply failures on the cluster status - #441
Open
ivanauth wants to merge 1 commit into
Open
fix: report deployment apply failures on the cluster status#441ivanauth wants to merge 1 commit into
ivanauth wants to merge 1 commit into
Conversation
When applying the SpiceDB deployment fails, for example because a user-provided patch produced an object the API server rejects, the error was only visible in operator logs while the cluster status gave no indication of the problem. Set a RolloutError condition with reason ApplyFailed before requeueing, and clear it again on the next successful apply. Signed-off-by: ivanauth <ivan@authzed.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #182
A patch that produces a Deployment the API server rejects was only logged, so the failure was invisible on the SpiceDBCluster. The apply error is now surfaced as a RolloutError condition with reason ApplyFailed, and cleared once an apply succeeds.