Merge master into production (#patch) - #215
Merged
Merged
Conversation
Exclude scripts directory for NPM package archive
…pmignore Replaces the .npmignore denylist with an explicit files allowlist, so new top-level files and build output are excluded by default rather than shipped by accident. index.js is covered by npm's implicit main inclusion; index.d.ts is not, so types is listed explicitly. Verified against the published 3.6.0 tarball: index.js, index.d.ts and all 56 lib/ files are unchanged; only .nvmrc, .prettierrc, AGENTS.md, tsconfig.json and scripts/ are dropped.
The root .DS_Store was committed to the repository. It never reached the published package, since npm-packlist ignores .DS_Store by default, but it does not belong in git. Untrack it and add it to .gitignore so the Finder files under lib/, test/ and build/ stay out too.
chore: allowlist published files via package.json files instead of .npmignore
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the npm publishing configuration for the Zigbee Cluster Library package, shifting from a .npmignore-based exclude list to an explicit package.json files allowlist, and adds an additional gitignore entry.
Changes:
- Added a
filesallowlist inpackage.jsonto control which artifacts are published to npm. - Removed
.npmignore(relying on the newfilesallowlist instead). - Added
.DS_Storeto.gitignore.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Introduces npm publish allowlist via files field. |
| .npmignore | Removes previous npm packaging exclude list. |
| .gitignore | Adds .DS_Store to ignored files. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+7
to
+10
| "files": [ | ||
| "index.d.ts", | ||
| "lib" | ||
| ], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.