fix: validate v3 channel parameters against address placeholders#1198
fix: validate v3 channel parameters against address placeholders#1198AayushSaini101 wants to merge 3 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: ae52fa6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| '$.channels.*', | ||
| '$.components.channels.*', | ||
| ], | ||
| then: { // NOSONAR |
There was a problem hiding this comment.
What’s the NOSONAR for?
| }, | ||
| (targetVal, _, ctx) => { | ||
| const { address, parameters } = targetVal; | ||
| if (!parameters || Object.keys(parameters).length === 0) return; |
There was a problem hiding this comment.
early returning on Object.keys(parameters).length === 0
means address: 'users/{userId}/signedUp' + parameters: {}
never reports missing userId.
how about removing that early return so empty parameters still runs getMissingProps?
princerajpoot20
left a comment
princerajpoot20
left a comment
There was a problem hiding this comment.
just few minor comments
|
2 participants
closes: #875