Skip to content

fix: external referenced schema names#1064

Open
DanielRamosAcosta wants to merge 2 commits into
asyncapi:masterfrom
DanielRamosAcosta:fix/referenced-schemas-name
Open

fix: external referenced schema names#1064
DanielRamosAcosta wants to merge 2 commits into
asyncapi:masterfrom
DanielRamosAcosta:fix/referenced-schemas-name

Conversation

@DanielRamosAcosta

Copy link
Copy Markdown

This PR just adds a test for reproducing the error in #1063

I would like to fix it, but I'm not sure where is the error, I would need guidance here.

@changeset-bot

changeset-bot Bot commented Nov 17, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: bfb4968

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarqubecloud

Copy link
Copy Markdown

const onUserLoggedChannel = channels[1]
const userRegisteredMessagePayload = onUserRegisteredChannel.messages().all()[0].payload()?.json() as any;
const userLoggedMessagePayload = onUserLoggedChannel.messages().all()[0].payload()?.json() as any;
expect(userRegisteredMessagePayload?.["x-parser-schema-id"]).toBe("UserRegistered");

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails. The actual value is <anonymous-schema-1>

@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@sonarqubecloud

Copy link
Copy Markdown

@github-actions github-actions Bot removed the stale label Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants