Add SesClient email identity operations#2106
Merged
jderusse merged 4 commits intoJul 13, 2026
Merged
Conversation
Generate getEmailIdentity, createEmailIdentity and putEmailIdentityDkimSigningAttributes operations for the SESv2 client. Also add the "SOA" acronym to the code generator so the SOARecord value object (returned by getEmailIdentity) can be generated.
Fill in the generated request/response unit tests with real fixtures so the getEmailIdentity, createEmailIdentity and putEmailIdentityDkimSigningAttributes operations are actually covered. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mfruehauf
marked this pull request as ready for review
July 3, 2026 14:03
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jderusse
reviewed
Jul 6, 2026
jderusse
left a comment
jderusse
left a comment
Member
There was a problem hiding this comment.
LGTM, just 2 minor comments about tests
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
Are there any other steps to take or any issues preventing this pull request from being merged? |
Member
|
Thank you @mfruehauf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following operations to the SESv2 client:
getEmailIdentitycreateEmailIdentityputEmailIdentityDkimSigningAttributesGenerated with
./generate Ses <Operation>.The code generator also learned the
SOAacronym so theSOARecordvalue object (returned bygetEmailIdentity) could be generated.The generated unit tests have been filled in with real request/response fixtures and pass locally (
phpunit,php-cs-fixerandphpstanall green). The integration tests remainmarkTestSkipped("No Docker image for SES"), consistent with the existing SES integration tests.🤖 Generated with Claude Code