feat(ui): OIDC "Log in with SSO" button#113
Merged
Merged
Conversation
Finishes the OIDC feature (backend shipped in #110). The login page now probes an unauthenticated /auth/oidc/enabled route (registered only when OIDC is configured) and, when present, renders a "Log in with SSO" button linking to /auth/oidc/login. When OIDC is off the route 404s and the button stays hidden. - server: OIDCHandler.register mounts /auth/oidc/enabled (200 + {"enabled":true}); it is only registered when auth.oidc.enabled, so its presence is the availability signal. - ui: Login.svelte probes it on mount and conditionally shows the SSO button (with an "or" divider) alongside the bearer-token form. Tests: the enabled probe returns 200 + enabled:true and is mounted by register(). npm run check clean, 50 UI tests pass. Remaining OIDC work: validation against a real IdP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the OIDC feature (backend shipped in #110) — the one follow-up I deferred there.
Change
OIDCHandler.registermounts an unauthenticated/auth/oidc/enabledroute (200 +{"enabled":true}). It is registered only whenauth.oidc.enabled, so its presence is the availability signal (404 = SSO off).Login.svelteprobes/auth/oidc/enabledon mount and, when present, renders a "Log in with SSO" button (with an "or" divider) alongside the bearer-token form, linking to/auth/oidc/login.Tests
The enabled probe returns 200 +
enabled:trueand is mounted byregister().npm run checkclean, 50 UI tests pass,make buildgreen.Remaining OIDC work: validation against a real IdP (the one step needing an actual provider).