fix(install): actionable error when proxmox:// DHCP IP discovery times out#112
Merged
Conversation
…s out Metal validation of the proxmox:// bootstrap surfaced a 10-minute silent hang: DHCP-mode IP discovery relies on the qemu-guest-agent, but the QGA-install cicustom snippet silently no-ops when the node storage cannot hold `snippets` content (e.g. an LVM-thin local-lvm), so the guest agent never installs and the DHCP lease is never reported. The old error was a bare "controller VM did not report an IP within 10m0s". Enrich the timeout error to name the likely cause (qemu-guest-agent not running / the snippet no-op) and the fix (re-run with ip=<CIDR>&gateway= <ip> for a static IP that skips guest-agent discovery). Turns a confusing hang into an actionable message. Test: the timeout branch (tiny budget) produces an error mentioning qemu-guest-agent + the static-IP workaround. Roadmap follow-up updated: the deeper fix (install QGA without depending on the disk storage, or fail fast at create time) remains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens the
proxmox://bootstrap path that metal validation just exercised.Problem (found on metal)
DHCP-mode bootstrap hung for 10 minutes then failed with a bare
controller VM did not report an IP within 10m0s. Root cause: IP discovery relies on the qemu-guest-agent, but the QGA-installcicustomsnippet silently no-ops when the node storage can't holdsnippetscontent (e.g. an LVM-thinlocal-lvm), so QGA never installs and the DHCP lease is never reported.Change (code-only, no infra)
Enrich the timeout error to name the likely cause (qemu-guest-agent not running / the snippet no-op) and the fix — re-run with
ip=<CIDR>&gateway=<ip>for a static IP that skips guest-agent discovery. Turns a confusing hang into an actionable message.Test: the timeout branch (tiny budget) produces an error mentioning
qemu-guest-agent+ the static-IP workaround.go vet/gofmt/golangci-lintclean.The deeper fix (install QGA without depending on the disk storage, or fail fast at create time — the client now has
ListNodeStoragesto pick a snippets-capable storage) remains a tracked roadmap follow-up.