Verify Rust downloads in Docker builds - #765
Draft
zaniebot wants to merge 3 commits into
Draft
Conversation
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker build pins the Rust version but executes
rustup-initwithout checking its hash. Rustup also fetches its toolchain manifest and checksum from the same distribution server, so the version pin does not independently constrain the downloaded toolchain bytes.Pin SHA-256 checksums for both Linux installers and the toolchain manifest. Install the minimal toolchain and musl target from a local mirror so Rustup checks each archive against the pinned manifest. Disable self-update and keep subsequent Rustup requests local. When changing
rust-toolchain.toml, updateRUST_VERSIONand its manifest checksum together.