PROD: feature-iu-email

src/app/api/notification/notification.helpers.test.ts

@@ -1,6 +1,7 @@
+import { NotificationTaskActions } from '@api/core/types/tasks'
 import { WorkspaceResponse } from '@/types/common'
-import { getReminderEmailDetails } from './notification.helpers'
-import { TaskReminderType } from '@prisma/client'
+import { getEmailDetails, getReminderEmailDetails } from './notification.helpers'
+import { Task, TaskReminderType } from '@prisma/client'
 
 const workspace: WorkspaceResponse = {
   id: 'ws_1',
@@ -76,3 +77,34 @@ describe('getReminderEmailDetails', () => {
     expect(htmlBody).not.toContain('<img src=x')
   })
 })
+
+describe('getEmailDetails', () => {
+  // Actions that email an IU recipient must have a template here, or the grouped
+  // buffer silently skips them (in-product fires but no email is ever flushed).
+  it.each([
+    NotificationTaskActions.Assigned,
+    NotificationTaskActions.ReassignedToIU,
+    NotificationTaskActions.Completed,
+    NotificationTaskActions.CompletedByIU,
+    NotificationTaskActions.CompletedByCompanyMember,
+    NotificationTaskActions.CompletedForCompanyByIU,
+  ])('defines an email template for IU-recipient action %s', (action) => {
+    const details = getEmailDetails(workspace, 'Arpan Two')[action]
+    expect(details).toBeDefined()
+    expect(details?.subject).toBeTruthy()
+    expect(details?.body).toBeTruthy()
+  })
+
+  it.each([
+    NotificationTaskActions.Completed,
+    NotificationTaskActions.CompletedByIU,
+    NotificationTaskActions.CompletedByCompanyMember,
+    NotificationTaskActions.CompletedForCompanyByIU,
+  ])('uses the task-marked-as-done copy for completion action %s', (action) => {
+    const details = getEmailDetails(workspace, 'Casey Client', task as unknown as Task)[action]
+    expect(details?.subject).toBe('Task marked as done')
+    expect(details?.header).toBe('A task has been completed')
+    expect(details?.body).toContain('has been marked as done by Casey Client')
+    expect(details?.title).toBe('View task')
+  })
+})

src/app/api/notification/notification.helpers.ts

@@ -166,6 +166,14 @@ export const getEmailDetails = (
         }
       : undefined
 
+  const completedDetail = {
+    subject: 'Task marked as done',
+    header: 'A task has been completed',
+    title: 'View task',
+    body: `The task ‘${task?.title}’ has been marked as done by ${actionUser}.\n\nTo see details about the task, open it below.`,
+    ctaParams,
+  }
+
   return {
     [NotificationTaskActions.Assigned]: {
       subject: 'A task was assigned to you',
@@ -181,13 +189,10 @@ export const getEmailDetails = (
       title: 'View task',
       ctaParams,
     },
-    //! Currently disable all IU email notifications
-    // [NotificationTaskActions.Completed]: {
-    //   title: 'A client completed a task',
-    //   subject: 'A client completed a task',
-    //   header: 'A client completed a task',
-    //   body: `A new task was completed by ${actionUser}. You are receiving this notification because you have access to the client.`,
-    // },
+    [NotificationTaskActions.Completed]: completedDetail,
+    [NotificationTaskActions.CompletedByIU]: completedDetail,
+    [NotificationTaskActions.CompletedByCompanyMember]: completedDetail,
+    [NotificationTaskActions.CompletedForCompanyByIU]: completedDetail,
     [NotificationTaskActions.Commented]: {
       subject: 'Comment was added',
       header: 'Comment was added',
@@ -202,6 +207,13 @@ export const getEmailDetails = (
       title: 'View task',
       ctaParams,
     },
+    [NotificationTaskActions.ReassignedToIU]: {
+      subject: 'A task was reassigned to you',
+      header: 'A task was reassigned to you',
+      title: 'View task',
+      body: `The task ‘${task?.title}’ was reassigned to you by ${actionUser}. To see details about the task open it below.`,
+      ctaParams,
+    },
     [NotificationTaskActions.ReassignedToClient]: {
       subject: 'A task was reassigned to you',
       header: 'A task was reassigned to you',