OUT-3904: add missing break in CommentToIU notification case - #1392
Closed
SandipBajracharya wants to merge 1 commit into
Closed
OUT-3904: add missing break in CommentToIU notification case#1392SandipBajracharya wants to merge 1 commit into
SandipBajracharya wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR stops comment notifications to internal users from entering the default notification path.
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(OUT-3904): add missing break in Comm..." | Re-trigger Greptile |
SandipBajracharya
changed the title
Potential fix — not confirmed as the definitive root cause. CommentToIU fell through into the default branch, which calls copilot.me() and parses its id. For tokens where me() resolves to null, that threw a ZodError and crashed comment notifications. Adding the missing break stops that fallthrough, which is the most likely trigger of the reported error. Fixes TASKS-9D Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
SandipBajracharya
force-pushed
the
OUT-3904
branch
from
July 13, 2026 11:20
ec3c3fa to
0de2063
Compare
Contributor
|
Deployment failed with the following error: Learn More: https://vercel.link/multiple-function-regions |
Collaborator
Author
|
Already made the same fix by @arpandhakal in one for the feature branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Potential fix for TASKS-9D / OUT-3904 — a
ZodErrorthrown fromNotificationService.getNotificationParties.The
CommentToIUcase in theswitch (action)was missing abreak, so it fell through into thedefaultbranch.defaultcallscopilot.me()and runsz.string().parse(userInfo?.id). For tokens whereme()resolves tonull(nointernalUserId/clientId), that parse throws the reportedZodErrorand crashes comment notifications — even though theCommentToIUcaller only consumesrecipientIds/senderCompanyId, both already set before the fallthrough.This adds the missing
break.Sentry
https://copilot-platforms.sentry.io/issues/TASKS-9D
Fixes TASKS-9D— will auto-close the Sentry issue on merge.🤖 Generated with Claude Code