Handle missing-token activity log requests - #1391
Draft
cursor[bot] wants to merge 4 commits into
Draft
Conversation
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
GET /api/activity-logs/[id]with the sharedwithErrorHandlerAPI wrapper.Testing Criteria
yarn test src/app/api/tests/routes/activity-log-route.test.ts src/app/api/tests/utils/withErrorHandler.test.ts --runInBand— 2 suites / 11 tests passed.yarn prettier:check— passed.yarn lint:check— passed with existing React hook/compiler warnings.yarn tsc— still fails only on the known pre-existing SVG module declaration errors insrc/icons/index.ts.Notes
Linearreturned 401; Sentry MCP requires auth), but the issue title exactly matches the Tasks API auth error thrown byauthenticatewhen notokenquery parameter is provided.Impact & Surface Area of Change
ActivityLogService#get; expected client/auth errors now follow the same response and logging behavior as the rest of the authenticated API routes.