Handle invalid /client launch tokens safely - #1387
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
getSafeTokenPayloadhelper that returnsnullfor malformed, unauthorized, or schema-invalid Copilot launch tokens while preserving unexpected error throws./clientto validate the token payload before issuing internal page data fetches, rendering the existing invalid-token UI for invalid launch tokens./clientSentry/dev-server noise for malformed values.Testing Criteria
yarn test src/utils/tokenPayload.test.ts --runInBandcovers valid payloads, impossible token strings, Copilot auth failures, malformed payloads, and unexpected errors.yarn lint:checkexits 0 (existing React hook/compiler warnings remain).yarn tscexits 0./client?token=invalid-tokenrenders "Please provide a Valid Token" and not "Something went wrong". Artifact:invalid_client_token_walkthrough_trimmed.mp4.Notes
Impact & Surface Area of Change
/clientlaunch-token handling only.