Fix client company resolution for grouped notification emails - #1384
Draft
cursor[bot] wants to merge 1 commit into
Draft
Fix client company resolution for grouped notification emails#1384cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
recipientCompanyIdbefore sending client-targeted grouped emails, grouped reminder emails, and reminder emails.Testing Criteria
yarn test src/jobs/notifications/send-grouped-email.test.ts src/jobs/notifications/send-grouped-reminder-email.test.ts src/jobs/notifications/send-reminder-email.test.ts src/jobs/notifications/flush-grouped-email.test.ts src/app/api/notification/notification.service.test.ts src/jobs/notifications/send-task-reminders.test.ts --runInBandTESTCONTAINERS_HOST_OVERRIDE=127.0.0.1 yarn test:integration src/jobs/notifications/flush-grouped-email.integration.test.ts --runInBandyarn lint:checkyarn tsccurrently fails on the pre-existing SVG module declaration errors insrc/icons/index.ts; no new type errors from this change were shown before that existing failure.Notes
TESTCONTAINERS_HOST_OVERRIDE=127.0.0.1because Testcontainers otherwise wrote a non-local172.18.0.1URL that the test guard refuses.Impact & Surface Area of Change
recipientCompanyId; existing payloads with a company id do not perform the extra lookup.