Guard comment activity IDs in task detail - #1382
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
getCommentActivityId/isPendingCommentIdhelpers for safe comment activity ID handling..includesor Zod string parsing on missing activitydetails.idvalues.temp-commenthandling while skipping malformed IDs instead of crashing the UI.Testing Criteria
yarn test src/utils/commentActivity.test.ts --runInBandpasses and covers missing/non-string IDs plus pending temp IDs.yarn lint:checkpasses with existing warnings only.yarn tsc --noEmitpasses.yarn test --runInBandwas also attempted: 17 suites / 143 tests passed, but the full suite failed insrc/app/api/tests/utils/authenticate.test.tsbecause Jest could not transform the ESMp-retrydependency (SyntaxError: Cannot use import statement outside a module). This failure is unrelated to the touched task-detail/comment files./detail/00000000-0000-0000-0000-000000000000/iu?token=fake-token; the app correctly blocked onFailed to authenticate token, so the task detail activity/comment UI could not be manually exercised without a real Copilot launch token.Notes
.includesreceivers.Impact & Surface Area of Change