Filter pushstate browser noise from Sentry - #1381
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
NS Pushstate preventionto the client ignored-error patterns so browser/Next/Sentry history instrumentation noise no longer creates Tasks Sentry issues.Testing Criteria
yarn test src/utils/sentryIgnoredErrors.test.ts --runInBandpassed.yarn lint:checkpassed with existing warnings only.yarn tscwas run; it is still blocked by pre-existing SVG module declaration errors insrc/icons/index.ts, with no new diagnostics from this change.Notes
next.config.jsconfirms Sentry uploads for projecttasks.Impact & Surface Area of Change
NS Pushstate preventionare dropped, while normal application errors should continue to report.