Skip to content

Guard Tapwrite editor submissions during popovers - #1349

Draft
cursor[bot] wants to merge 3 commits into
mainfrom
cursor/OUT-3910-cursor-automated-triage-response-9313
Draft

Guard Tapwrite editor submissions during popovers#1349
cursor[bot] wants to merge 3 commits into
mainfrom
cursor/OUT-3910-cursor-automated-triage-response-9313

Conversation

@cursor

@cursor cursor Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Added shared Tapwrite editor-state guards for active Tippy popovers and ProseMirror position clamping.
  • Prevented comment/reply create and edit submissions from clearing/resetting Tapwrite content while slash/autofill popovers are active.
  • Clamped title-editor drag/drop insertion and selection positions before calling ProseMirror selection APIs.
  • Added focused unit coverage for the new guard and clamping behavior.

Testing Criteria

  • yarn test src/utils/tapwriteEditorState.test.ts --runInBand — passes, covering active menu detection, submission blocking, and position clamping.
  • yarn lint:check — passes with existing warning-only output.
  • yarn tsc — attempted; fails only on the repo's pre-existing SVG module declaration errors in src/icons/index.ts.
  • Manual browser smoke check — Next dev server starts and renders, but Tapwrite editor routes are blocked without a valid Copilot token, showing only the existing invalid-token UI.

Notes

  • Linear MCP returned auth_revoked, and the Sentry MCP server requires authentication, so direct Sentry event inspection and Linear metadata confirmation were unavailable.
  • The local repo Sentry upload config targets project tasks, and the trigger issue was in Triage, so this PR addresses the most plausible Tasks-app root cause for RangeError: Position -7 out of range from Tiptap/ProseMirror suggestion ranges.

Impact & Surface Area of Change

  • Comment and reply editors: Enter/Ctrl+Enter and button submit/edit paths now no-op while Tapwrite/Tippy menus are active.
  • Template/title editor drag-and-drop: ProseMirror insertion and selection positions are clamped to document bounds to avoid out-of-range resolution errors.
Open in Web View Automation 

cursoragent and others added 3 commits June 25, 2026 13:46
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
@linear-code

linear-code Bot commented Jun 25, 2026

Copy link
Copy Markdown

OUT-3910

@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tasks-app Ready Ready Preview, Comment Jun 25, 2026 1:59pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant