Skip to content

Fix notification count validation without Tasks app id - #1345

Draft
cursor[bot] wants to merge 3 commits into
mainfrom
cursor/OUT-3904-cursor-automated-triage-response-8926
Draft

Fix notification count validation without Tasks app id#1345
cursor[bot] wants to merge 3 commits into
mainfrom
cursor/OUT-3904-cursor-automated-triage-response-8926

Conversation

@cursor

@cursor cursor Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Parse COPILOT_APP_ID/legacy COPILOT_APP_API_KEY as an optional UUID instead of throwing a raw ZodError.
  • Skip client notification-count reconciliation when the Tasks app id is not configured, avoiding unsafe cross-app cleanup.
  • Keep Copilot notification lookup scoped to the configured Tasks app id when present.
  • Add focused regression tests for missing app id and app/company filtering.

Testing Criteria

  • yarn test "src/utils/CopilotAPI.notifications.test.ts" "src/app/api/notification/validate-count/validateCount.service.test.ts" --runInBand
  • yarn lint:check
  • yarn tsc --noEmit attempted; fails only on the known pre-existing SVG module declaration errors from src/icons/index.ts.

Notes

  • Linear/Sentry source details could not be fetched directly because Linear MCP returned auth_revoked and Sentry MCP requires authentication. The fix addresses the matching raw ZodError: [ path found in Tasks notification validation.
  • Runtime config should prefer COPILOT_APP_ID; COPILOT_APP_API_KEY remains as a legacy fallback only if it contains a UUID.

Impact & Surface Area of Change

  • Affects the client notification-count validation route and Copilot notification filtering only.
  • Main regression area: client notification badge/count reconciliation for environments with a configured Tasks app id.
Open in Web View Automation 

cursoragent and others added 3 commits June 24, 2026 13:27
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
@linear-code

linear-code Bot commented Jun 24, 2026

Copy link
Copy Markdown

OUT-3904

@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tasks-app Ready Ready Preview, Comment Jun 24, 2026 1:31pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant