Fix notification count validation without Tasks app id - #1345
Draft
cursor[bot] wants to merge 3 commits into
Draft
Fix notification count validation without Tasks app id#1345cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
COPILOT_APP_ID/legacyCOPILOT_APP_API_KEYas an optional UUID instead of throwing a raw ZodError.Testing Criteria
yarn test "src/utils/CopilotAPI.notifications.test.ts" "src/app/api/notification/validate-count/validateCount.service.test.ts" --runInBandyarn lint:checkyarn tsc --noEmitattempted; fails only on the known pre-existing SVG module declaration errors fromsrc/icons/index.ts.Notes
auth_revokedand Sentry MCP requires authentication. The fix addresses the matching rawZodError: [path found in Tasks notification validation.COPILOT_APP_ID;COPILOT_APP_API_KEYremains as a legacy fallback only if it contains a UUID.Impact & Surface Area of Change