fix: skip notification validation without Copilot app id - #1344
Draft
cursor[bot] wants to merge 3 commits into
Draft
fix: skip notification validation without Copilot app id#1344cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
COPILOT_APP_IDas the notification app identifier, with the existingCOPILOT_APP_API_KEYvalue as fallback.ZodErrorcrashes and preventing unsafe repair work against unfiltered notifications.Testing Criteria
yarn test src/utils/CopilotAPI.notifications.test.ts src/app/_fetchers/ValidateNotificationCountFetcher.test.tsx --runInBandcovers missing app-id no-op behavior and configured app-id filtering.yarn lint:checkexits successfully with existing warnings only.yarn tscwas run; it still fails on pre-existing missing SVG module declarations insrc/icons/index.ts, with no diagnostics from the changed files.Notes
auth_revoked/needsAuth), so the issue source and stack trace could not be directly re-read from Linear/Sentry. The implemented fix targets the current Tasks code path that can produce the observedZodError: [title when notification app-id env is absent.Impact & Surface Area of Change
/clientand/api/notification/validate-count.