OUT-3617-new: AB feature-testing gate for the bank deposit flow

[SandipBajracharya]

Problem

The bank-deposit flow is going out to a limited set of portals (Permit Pushers) first, not all at once.

Shipped

An env-driven allowlist gate. AB_FEATURE_TESTING_PORTALS (comma-separated portalIds) controls availability; empty/unset = available to all portals (full-rollout default). Backed by isPortalInBankDepositABTest(portalId).

Gated at exactly the points that decide behavior:

• Freeze — InvoiceService.readBankDepositFeeFlag(): excluded portals freeze invoices non-batched regardless of the stored flag.
• Reconcile — top of PayoutService.reconcile(): excluded portals short-circuit to { depositId: null }, covering both the payout webhook and the resync cron. Logged (not silent) so a rare mid-flight exclusion is visible.
• Settings — write path strips the flag + bank account for non-AB portals; GET returns bankDepositEnabled.
• UI — checkbox + bank-account dropdown hidden when off; bank-account fetch skipped.

No schema changes, no migrations.

Code sites

• src/config/index.ts, src/utils/abTesting.ts
• src/app/api/quickbooks/invoice/invoice.service.ts, payout/payout.service.ts, setting/setting.controller.ts
• src/hook/useSettings.ts, components/dashboard/settings/SettingAccordion.tsx, .../invoice/InvoiceDetail.tsx

Tests

Unit: gate util, freeze gate, reconcile gate, settings write path + bankDepositEnabled. Integration: real webhook → invoice.service → DB proves an excluded portal freezes non-batched. Full suite green (282 unit / 117 integration), tsc + lint + prettier clean.

Rollout

Set AB_FEATURE_TESTING_PORTALS in Vercel (all environments) as part of enabling the feature.

🤖 Generated with Claude Code

[linear-code]

OUT-3617

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
quickbooks-sync	Ready	Preview	Aug 3, 2026 8:58am

[greptile-apps]

Greptile Summary

Adds an environment-driven portal allowlist for incrementally rolling out the bank-deposit flow, with an empty allowlist retaining full availability.

• Applies the gate when freezing invoice deposit intent and reconciling payouts.
• Prevents excluded portals from writing bank-deposit settings and exposes the gate state to the settings UI.
• Hides bank-deposit controls and skips bank-account loading for excluded portals.
• Adds unit and integration coverage for gate parsing and affected service paths.

Confidence Score: 5/5

The PR appears safe to merge under the documented fixed-before-rollout allowlist operation.

No blocking failure remains; the previously reported mid-flight exclusion scenario was explicitly identified as outside the supported rollout model because individual portals will not be removed after enablement.

Important Files Changed

Filename	Overview
src/utils/abTesting.ts	Implements the shared portal-membership gate with the documented full-rollout default for an empty allowlist.
src/config/index.ts	Parses and normalizes the comma-separated portal allowlist at module initialization.
src/app/api/quickbooks/invoice/invoice.service.ts	Ensures excluded portals freeze new invoices without batched-deposit intent.
src/app/api/quickbooks/payout/payout.service.ts	Short-circuits deposit reconciliation for excluded portals under the documented fixed allowlist rollout model.
src/app/api/quickbooks/setting/setting.controller.ts	Gates bank-deposit setting writes and returns feature availability to invoice-settings clients.
src/hook/useSettings.ts	Consumes server-provided availability and avoids fetching bank accounts while the feature is disabled.
src/components/dashboard/settings/sections/invoice/InvoiceDetail.tsx	Conditionally renders the bank-deposit controls according to the server-provided gate state.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Portal request or sync event] --> B{Allowlist empty?}
    B -->|Yes| C[Bank deposit feature enabled]
    B -->|No| D{Portal ID allowlisted?}
    D -->|Yes| C
    D -->|No| E[Bank deposit feature disabled]
    C --> F[Allow settings and freeze batched intent]
    C --> G[Reconcile payout into deposit]
    E --> H[Hide and strip bank-deposit settings]
    E --> I[Freeze invoices as non-batched]
    E --> J[Skip payout reconciliation]

Loading

_{Reviews (2): Last reviewed commit: "test(OUT-3617): cover the bank-deposit A..." | Re-trigger Greptile}

[SandipBajracharya]

@greptileai review the PR again

[priosshrsth]

lgtm