Skip to content

chore(OUT-4005): test typecheck CI + stale test-type fixes [4/4] - #276

Merged
SandipBajracharya merged 1 commit into
feature/payout-reconciliationfrom
OUT-4005-split-4
Aug 3, 2026
Merged

chore(OUT-4005): test typecheck CI + stale test-type fixes [4/4]#276
SandipBajracharya merged 1 commit into
feature/payout-reconciliationfrom
OUT-4005-split-4

Conversation

@SandipBajracharya

Copy link
Copy Markdown
Collaborator

Stack 4/4 — base: OUT-4005-split-3

Adds yarn typecheck:test (tsc over test/tsconfig.json) and a CI job so type errors in tests gate PRs — the main tsconfig excludes test/, so nothing typechecked tests before. Fixes the pre-existing type errors it surfaces (missing bankAccountRef fixtures, stale UnitPrice input, string status/id) and loads the ambient shims in test/tsconfig. Adds CLAUDE.md.

Part of the OUT-4005 payout-reconciliation stack:

  1. schema + migration
  2. reconciliation service + deposit lookup
  3. webhook + resync wiring
  4. typecheck tooling + chore ← this PR

🤖 Generated with Claude Code

@linear-code

linear-code Bot commented Jul 31, 2026

Copy link
Copy Markdown

OUT-4005

@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
quickbooks-sync Building Building Aug 3, 2026 8:35am
quickbooks-sync (dev) Ready Ready Preview Aug 3, 2026 8:35am

Request Review

@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown

Greptile Summary

Adds test-file typechecking as a required pull-request CI job.

  • Adds the typecheck:test package script and GitHub Actions job.
  • Loads the tracked intuit-oauth ambient declaration without loading the missing generated or dependency-backed declarations reported previously.
  • Updates stale test fixtures and inputs to satisfy current application types.
  • Adds repository development guidance in CLAUDE.md.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
test/tsconfig.json Restricts test typechecking to test TypeScript files and the tracked, self-contained Intuit ambient declaration; both previously reported declaration-loading failures are absent.
.github/workflows/test.yml Adds an isolated pull-request job that installs dependencies and runs the new test typecheck command.
package.json Adds a TypeScript no-emit command using the dedicated test configuration.
test/integration/quickbooks/invoicePaid/frozenIntentRouting.test.ts Removes stale status fixture overrides so the tests use the current seed contract.
test/unit/utils/intuitAPI.responses.test.ts Updates Intuit API fixtures and item input to conform to current types.

Reviews (3): Last reviewed commit: "chore(OUT-4005): add test typecheck scri..." | Re-trigger Greptile

Comment thread test/tsconfig.json Outdated
@SandipBajracharya

Copy link
Copy Markdown
Collaborator Author

@greptileai review whole PR again

Comment thread test/tsconfig.json Outdated
@SandipBajracharya

Copy link
Copy Markdown
Collaborator Author

@greptileai review again

@priosshrsth priosshrsth left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from OUT-4005-split-3 to feature/payout-reconciliation August 3, 2026 08:44
…ypes

Adds yarn typecheck:test (tsc over test/tsconfig.json) and a CI job so type
errors in tests gate PRs. Fixes the pre-existing type errors it surfaces
(missing bankAccountRef fixtures, stale UnitPrice input, string status/id) and
loads the ambient shims in test/tsconfig. Also adds CLAUDE.md.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@SandipBajracharya
SandipBajracharya merged commit 3e98ab3 into feature/payout-reconciliation Aug 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants