fix(OUT-3607): return empty array when QB has no service items - #228
Merged
Conversation
QuickBooks omits the Item key from QueryResponse when the Item SQL query matches zero rows, causing QBItemsResponseSchema.parse to throw a ZodError (expected array, received undefined). Default to [] so the /api/quickbooks/product/qb/item route and the product backfill gracefully handle companies with no service items. Fixes ACCOUNTING-SYNC-2X Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
arpandhakal
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/quickbooks/product/qb/itemthrewZodError: expected array, received undefinedwhen a QuickBooks company had zero Service items — QB omits theItemkey fromQueryResponseon empty result sets, soQBItemsResponseSchema.parse(qbItems.Item)receivedundefined.[]before parsing in_getAllItems(src/utils/intuitAPI.ts:415). Both callers (product.service.ts#queryItemsFromQB,backfillProductInfo.service.ts) already tolerate an empty array.Fixes ACCOUNTING-SYNC-2X · Linear OUT-3607
Test plan
/api/quickbooks/product/qb/itemreturns[](not 500) for a QB sandbox company with no Service items.[]return (short-circuits viaallQbItems?.find).🤖 Generated with Claude Code