OUT-3609: bank account selector dropdown for invoice settings - #226
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SandipBajracharya
force-pushed
the
OUT-3609
branch
from
April 17, 2026 14:41
02aa9e0 to
953ac6f
Compare
SandipBajracharya
force-pushed
the
OUT-3604
branch
from
April 20, 2026 10:53
f1c86b7 to
801e818
Compare
SandipBajracharya
force-pushed
the
OUT-3609
branch
from
April 20, 2026 10:54
ab2bab2 to
dc21c89
Compare
SandipBajracharya
changed the title
arpandhakal
approved these changes
Apr 20, 2026
…s UI - Add bank account dropdown in InvoiceDetail below bankDepositFeeFlag checkbox - Fetch QBO bank accounts via SWR (GET /api/quickbooks/setting/bank-account) - Include bankAccountRef in settingState for single-request save - Add click-outside-to-close, loading state, and amber warning when unselected - Pass bankAccounts, isBankAccountsLoading, selectBankAccount props via SettingAccordion Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…t bank account Block the Confirm/Update button when bankDepositFeeFlag is on but no bank account is selected. Without a bank account, the webhook deposit flow throws on every payment.succeeded event. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
SandipBajracharya
force-pushed
the
OUT-3609
branch
from
April 21, 2026 05:45
dc21c89 to
18f49d0
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bankDepositFeeFlagcheckbox)GET /api/quickbooks/setting/bank-account)bankAccountRefinsettingStatefor single-request saveSettingAccordion→InvoiceDetailFiles changed
src/hook/useSettings.ts—useInvoiceDetailSettingshook: bank account state, SWR fetch, single API call submitsrc/components/dashboard/settings/sections/invoice/InvoiceDetail.tsx— custom dropdown UIsrc/components/dashboard/settings/SettingAccordion.tsx— prop passthroughTest plan
absorbedFeeFlag→bankDepositFeeFlagcheckbox appearsbankDepositFeeFlag→ bank account dropdown appears, loads QBO accountsabsorbedFeeFlag→ dropdown and deposit checkbox disappear🤖 Generated with Claude Code