Skip to content

OUT-3975 | Profile Manager App - Company custom fields are showing but tags are not #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arpandhakal merged 1 commit into from
Jul 14, 2026
Merged

OUT-3975 | Profile Manager App - Company custom fields are showing but tags are not #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/types/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ export const CustomFieldSchema = z.object({
}),
)
.optional(),
entityType: z.string(),

@greptile-apps greptile-apps Bot Jul 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing entity type rejects response

When listCustomFields() returns a field without entityType—for example from an older API response—the schema throws before the filter runs. Every getCustomFields() caller then fails instead of returning its custom-field data, so make this field optional or use the response field guaranteed by the API.

@arpandhakal arpandhakal Jul 14, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the api guarantees the entityType prop @greptile

@greptile-apps greptile-apps Bot Jul 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough — if the API contract guarantees entityType is always present, then a required field in the schema is the right call. It'll correctly reject any malformed response rather than silently passing through bad data. I'll withdraw the concern.

Tip: You can customize Greptile's behavior for this repo with .greptile/rules.md and .greptile/config.json.

});
export type CustomField = z.infer<typeof CustomFieldSchema>;
export const CustomFieldResponseSchema = z.object({
Expand Down
3 changes: 2 additions & 1 deletion src/utils/copilotApiUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ export class CopilotAPI {
}

async getCustomFields(): Promise<CustomFieldResponse> {
return CustomFieldResponseSchema.parse(await this.copilot.listCustomFields());
const response = CustomFieldResponseSchema.parse(await this.copilot.listCustomFields());
return { ...response, data: response.data?.filter((field) => field.entityType === 'client') ?? [] };
}
}
Loading