Skip to content

OUT-3989: L0.5 — run lint + type-check on pull_request - #123

Merged
SandipBajracharya merged 1 commit into
mainfrom
OUT-3989
Aug 7, 2026
Merged

OUT-3989: L0.5 — run lint + type-check on pull_request#123
SandipBajracharya merged 1 commit into
mainfrom
OUT-3989

Conversation

@SandipBajracharya

Copy link
Copy Markdown
Collaborator

L0.5 — CI wiring

Linear: OUT-3989 · parent OUT-3984 · base branch: OUT-3988

Context

Most of L0.5 was already delivered under OUT-3985test.yml splits unit vs integration jobs, Testcontainers uses the ubuntu-latest Docker daemon (no services: needed), pnpm deps are cached, and both jobs run the existing pnpm test / test:integration scripts. This PR closes the one worthwhile remaining gap.

Change

code-quality.yml ran on: push only, so lint + type-check did not gate pull requests (including fork PRs), while test.yml runs on both push and pull_request. This aligns the trigger:

-on: push
+on:
+  push:
+  pull_request:

Deliberately not included: Docker-layer image caching

The ticket names Docker-layer caching, but it's declined on cost/benefit grounds: postgres:17-alpine is ~30 MB, so actions/cache + docker save/load costs about as much as the pull (a known anti-pattern for small images), and it wouldn't cover Testcontainers' Ryuk image. The only risk that would justify it — Docker Hub rate limits — is properly solved with registry auth, not a tarball cache, and isn't currently biting. Revisit with docker/login-action if toomanyrequests ever appears.

🤖 Generated with Claude Code

@linear-code

linear-code Bot commented Aug 5, 2026

Copy link
Copy Markdown

OUT-3989

@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown

Greptile Summary

This PR extends the code-quality workflow to run on pull requests, including fork PRs, so linting and type-checking can gate proposed changes.

  • Retains the existing push trigger.
  • Adds the pull_request trigger.
  • Leaves workflow permissions and job behavior unchanged.

Confidence Score: 5/5

The PR appears safe to merge, with the pull-request trigger compatible with the workflow’s existing read-only jobs and permissions.

The changed workflow continues to run the same lint and type-check commands without secrets or write permissions, and those steps are compatible with fork pull requests.

Important Files Changed

Filename Overview
.github/workflows/code-quality.yml Adds a valid pull-request trigger to the existing read-only lint and type-check workflow without introducing permission, secret, or execution-path issues.

Reviews (1): Last reviewed commit: "ci(OUT-3989): run lint + type-check on p..." | Re-trigger Greptile

code-quality.yml ran on push only, so lint + typecheck did not gate PRs
(incl. fork PRs). Match test.yml's push + pull_request triggers so both
checks gate pull requests too.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@SandipBajracharya
SandipBajracharya changed the base branch from OUT-3988 to main August 7, 2026 08:15
@SandipBajracharya SandipBajracharya changed the title ci(OUT-3989): L0.5 — run lint + type-check on pull_request OUT-3989: L0.5 — run lint + type-check on pull_request Aug 7, 2026
@vercel

vercel Bot commented Aug 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dropbox-integration Ready Ready Preview Aug 7, 2026 8:17am

Request Review

@SandipBajracharya
SandipBajracharya merged commit 6da876d into main Aug 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants