OUT-3989: L0.5 — run lint + type-check on pull_request - #123
Merged
Conversation
Greptile SummaryThis PR extends the code-quality workflow to run on pull requests, including fork PRs, so linting and type-checking can gate proposed changes.
Confidence Score: 5/5The PR appears safe to merge, with the pull-request trigger compatible with the workflow’s existing read-only jobs and permissions. The changed workflow continues to run the same lint and type-check commands without secrets or write permissions, and those steps are compatible with fork pull requests. Important Files Changed
Reviews (1): Last reviewed commit: "ci(OUT-3989): run lint + type-check on p..." | Re-trigger Greptile |
priosshrsth
approved these changes
Aug 6, 2026
SandipBajracharya
force-pushed
the
OUT-3988
branch
from
August 7, 2026 08:12
18cab33 to
3ad402a
Compare
code-quality.yml ran on push only, so lint + typecheck did not gate PRs (incl. fork PRs). Match test.yml's push + pull_request triggers so both checks gate pull requests too. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
SandipBajracharya
force-pushed
the
OUT-3989
branch
from
August 7, 2026 08:15
9c3e93a to
bc763ee
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
L0.5 — CI wiring
Linear: OUT-3989 · parent OUT-3984 · base branch:
OUT-3988Context
Most of L0.5 was already delivered under OUT-3985 —
test.ymlsplits unit vs integration jobs, Testcontainers uses theubuntu-latestDocker daemon (noservices:needed), pnpm deps are cached, and both jobs run the existingpnpm test/test:integrationscripts. This PR closes the one worthwhile remaining gap.Change
code-quality.ymlranon: pushonly, so lint + type-check did not gate pull requests (including fork PRs), whiletest.ymlruns on bothpushandpull_request. This aligns the trigger:Deliberately not included: Docker-layer image caching
The ticket names Docker-layer caching, but it's declined on cost/benefit grounds:
postgres:17-alpineis ~30 MB, soactions/cache+docker save/loadcosts about as much as the pull (a known anti-pattern for small images), and it wouldn't cover Testcontainers' Ryuk image. The only risk that would justify it — Docker Hub rate limits — is properly solved with registry auth, not a tarball cache, and isn't currently biting. Revisit withdocker/login-actioniftoomanyrequestsever appears.🤖 Generated with Claude Code