test: cover the duration operators on a datetime attribute - #816
Merged
zachdaniel merged 1 commit intoAug 17, 2026
Merged
Conversation
Contributor
|
I'm cool with tests failing for now 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.
Summary
Partially delivers #553 (Duration)
Requires ash PR ash-project/ash#2852 to release before this merges
Tests only. This PR tests
attribute + duration,attribute - duration, a multi-unit duration, the duration on the left, and both operands as expressions.Against released ash 3.31.3 all six fail with
Invalid filter value %Duration{...}, becauseplus/minusdeclare no types and the duration is typed as the datetime it is added to. CI here resolves ash from Hex, so this stays red until that releases; as #814 was until ash_sql 0.6.8.Independent of #815.
Tested with Postgres 19.