refactor: add a .size field to asdf_extension_t#232
Merged
Conversation
This records the size (in bytes) of the extension object. This is useful for dynamic allocation, where e.g. a generic extension object allocator does not know the type of the object it's constructing, but needs to know at least the correct size for the object. This is used in libasdf-gwcs where there are "class hierarchies" where the generic base allocator would need to know the size of the objects for "subclasses" without knowing the actual type of the subclass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This records the size (in bytes) of the extension object. This is useful for dynamic allocation, where e.g. a generic extension object allocator does not know the type of the object it's constructing, but needs to know at least the correct size for the object. This is used in libasdf-gwcs where there are "class hierarchies" where the generic base allocator would need to know the size of the objects for "subclasses" without knowing the actual type of the subclass.
Arguably this would be a case for adding some
.allocand/or.initmethod for extensions, but for the present purposes that's more than would be needed.