Expose ASDF_ERROR_ macros and extension copy updates#230
Merged
Conversation
Mostly this is just used for error reporting when copying extension values, since errors typically go through a file (avoiding using the library global error context, which is better also for extension authors). Having this might also be useful in the future for other reasons, such as using custom allocators associated with a file (which might also necessitate adding this to the dealloc method but we'll cross that bridge when we get there)
These are here primarily for use by third-party extension code to set errors on the file. Also some general cleanup of the error handling code and various accumulated cruft from past revisions. I'm still not entirely happy with it...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #229 and improves the ability to report errors in
asdf_<extension>_clonemethods.AI Disclosure
No AI tools used.