fix(semantic-search): process AI Search indexing in batches#69
Merged
Conversation
Remove embedding model validation from the AI Search backend so the bound Cloudflare AI Search instance remains the source of truth for embedding model configuration.
Greptile SummaryThis PR adds Cloudflare AI Search support for semantic search. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (3): Last reviewed commit: "refactor(semantic-search): inline worker..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
aryasaatvik
added a commit
that referenced
this pull request
Jun 27, 2026
## Summary Simplifies the semantic-search vector embedding API to a single AI SDK-backed `makeEmbedder` contract. Hosts now create provider models and pass an explicit embedder into the vector backend. ## Changes - Replace Gemini, Cloudflare Workers AI, and raw OpenAI-compatible plugin constructors with generic `makeEmbedder`. - Remove provider-specific vector backend options such as `workersAi`, `geminiApiKey`, and embedder model config. - Keep provider construction only in the local eval harness and add focused tests for batching, provider options, and dimension validation. ## Tests - `./node_modules/.bin/oxfmt --check packages/plugins/semantic-search/src/sdk/embedder.ts packages/plugins/semantic-search/src/sdk/embedder.test.ts packages/plugins/semantic-search/src/sdk/embedding-service.ts packages/plugins/semantic-search/src/sdk/eval.ts packages/plugins/semantic-search/src/sdk/index.ts packages/plugins/semantic-search/src/sdk/tool-search-backend.ts packages/plugins/semantic-search/package.json packages/plugins/semantic-search/tsup.config.ts` - `./node_modules/.bin/oxlint -c .oxlintrc.jsonc packages/plugins/semantic-search/src/sdk/embedder.ts packages/plugins/semantic-search/src/sdk/embedder.test.ts packages/plugins/semantic-search/src/sdk/embedding-service.ts packages/plugins/semantic-search/src/sdk/eval.ts packages/plugins/semantic-search/src/sdk/index.ts packages/plugins/semantic-search/src/sdk/tool-search-backend.ts --deny-warnings` - `bun run --filter @executor-js/plugin-semantic-search test -- src/sdk/embedder.test.ts src/sdk/plugin.test.ts src/sdk/search.test.ts` - `bun run --filter @executor-js/plugin-semantic-search typecheck` - `bun run --filter @executor-js/plugin-semantic-search test` <!-- stack:links:start --> ### [Stack](https://github.com/aryasaatvik/stack) 1. #69 2. **#70** 👈 current <!-- stack:links:end -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Stack